shalinmangar commented on a change in pull request #1402: SOLR-12720 Deprecated 
Auto Add Replica in XML
URL: https://github.com/apache/lucene-solr/pull/1402#discussion_r403454201
 
 

 ##########
 File path: solr/solr-ref-guide/src/solrcloud-autoscaling-triggers.adoc
 ##########
 @@ -205,10 +205,29 @@ to add replicas on the live nodes to maintain the 
expected replication factor).
 
 Refer to the section 
<<solrcloud-autoscaling-auto-add-replicas.adoc#solrcloud-autoscaling-auto-add-replicas,
 Autoscaling Automatically Adding Replicas>> to learn more about how the 
`.autoAddReplicas` trigger works.
 
-In addition to the parameters described at <<Trigger Configuration>>, this 
trigger supports one parameter, which is defined in the `<solrcloud>` section 
of `solr.xml`:
+If you would like to change the value of `.autoAddReplicas` trigger, you need 
to call the autoscaling API and use the `set-trigger` command to add a value 
for `waitFor`.
 
-`autoReplicaFailoverWaitAfterExpiration`::
-The minimum time in milliseconds to wait for initiating replacement of a 
replica after first noticing it not being live. This is important to prevent 
false positives while stopping or starting the cluster. The default is `120000` 
(2 minutes). The value provided for this parameter is used as the value for the 
`waitFor` parameter in the `.auto_add_replicas` trigger.
+.Example: Updating Trigger with wait for 5 seconds
+----
+{
+  "set-trigger": {
+    "name": "auto_add_replicas",
 
 Review comment:
   This name should be `.auto_add_replicas` (notice the leading `.` dot 
character)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to