CaoManhDat commented on a change in pull request #1470:
URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418404455
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java
##########
@@ -243,12 +233,13 @@ public ShardResponse takeCompletedOrError() {
}
private ShardResponse take(boolean bailOnError) {
+ try {
+ while (pending.get() > 0) {
+ ShardResponse rsp = responses.take();
+ if (rsp == END_QUEUE)
Review comment:
So all usage of HttpShardHandler is single-thread. Submit tasks,
takeResponse then cancelAll() if there are anyerror. Therefore even END_QUEUE
is not needed here. I may add some comments to indicate that HttpShardHandler
is not thread-safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
