tflobbe commented on a change in pull request #1456:
URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418772556
##########
File path: solr/core/src/java/org/apache/solr/response/JSONWriter.java
##########
@@ -132,11 +133,16 @@ public void writeSolrDocument(String name, SolrDocument
doc, ReturnFields return
// that the size could not be reliably determined.
//
+ /**
+ * This method will be removed in Solr 9
Review comment:
I really don't think we need to keep this around longer than 9.0. People
upgrading a major version expect to have to change some code. This is a trivial
change, they'll get a compile-time error and notice there is a new parameter
added. This doesn't even change the client, just plugins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
