jpountz commented on a change in pull request #1456:
URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r416972950
##########
File path: solr/core/src/java/org/apache/solr/search/MaxScoreCollector.java
##########
@@ -39,7 +39,7 @@ public float getMaxScore() {
public ScoreMode scoreMode() {
// Should be TOP_SCORES but this would wrap the scorer unnecessarily since
// this collector is only used in a MultiCollector.
- return ScoreMode.COMPLETE;
+ return ScoreMode.TOP_SCORES;
Review comment:
Yeah I think that at some point we tried not to wrap the scorer when all
score modes were `COMPLETE` but apparently now we do, so this comment is stale.
https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/search/MultiCollector.java#L158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
