mbwaheed commented on a change in pull request #1430:
URL: https://github.com/apache/lucene-solr/pull/1430#discussion_r425524750



##########
File path: 
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java
##########
@@ -1465,4 +1318,30 @@ private void zkCheck() {
 
     throw new SolrException(SolrException.ErrorCode.SERVICE_UNAVAILABLE, 
"Cannot talk to ZooKeeper - Updates are disabled.");
   }
+
+  private boolean isSharedCoreAddOrDeleteGoingToBeIndexedLocally() {
+    // forwardToLeader: if true, then the update is going to be forwarded to 
its rightful leader.
+    //                  The doc being added or deleted might not even belongs 
to the current core's (req.getCore()) shard.
+    // isLeader: if true, then the current core (req.getCore()) is the leader 
of the shard to which the doc being added or deleted belongs to.
+    //           For SHARED replicas only leader replicas do local indexing. 
Follower SHARED replicas do not do any local 
+    //           indexing and there only job is to forward the updates to the 
leader replica.
+    // isSubShardLeader: if true, then the current core (req.getCore()) is the 
leader of a sub shard being built.
+    //                   Sub shard leaders only buffer the updates locally and 
apply them towards the end of a successful

Review comment:
       yes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to