ErickErickson commented on a change in pull request #1533:
URL: https://github.com/apache/lucene-solr/pull/1533#discussion_r429638118
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/StatsComponent.java
##########
@@ -167,89 +167,91 @@ public void finishStage(ResponseBuilder rb) {
public String getDescription() {
return "Calculate Statistics";
}
-}
-/**
- * Models all of the information about stats needed for a single request
- * @see StatsField
- */
-class StatsInfo {
-
- private final ResponseBuilder rb;
- private final List<StatsField> statsFields = new ArrayList<>(7);
- private final Map<String, StatsValues> distribStatsValues = new
LinkedHashMap<>();
- private final Map<String, StatsField> statsFieldMap = new LinkedHashMap<>();
- private final Map<String, List<StatsField>> tagToStatsFields = new
LinkedHashMap<>();
-
- public StatsInfo(ResponseBuilder rb) {
- this.rb = rb;
- SolrParams params = rb.req.getParams();
- String[] statsParams = params.getParams(StatsParams.STATS_FIELD);
- if (null == statsParams) {
- // no stats.field params, nothing to parse.
- return;
- }
-
- for (String paramValue : statsParams) {
- StatsField current = new StatsField(rb, paramValue);
- statsFields.add(current);
- for (String tag : current.getTagList()) {
- List<StatsField> fieldList = tagToStatsFields.get(tag);
- if (fieldList == null) {
- fieldList = new ArrayList<>();
+
+ /**
+ * Models all of the information about stats needed for a single request
+ *
+ * @see StatsField
+ */
+ static class StatsInfo {
Review comment:
Yeah, lost track of that, thanks for pointing it out! It'll be in the
next PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
