dsmiley commented on a change in pull request #1572:
URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r439936737
##########
File path: solr/core/src/test-files/solr/solr-50-all.xml
##########
@@ -24,6 +24,7 @@
<str name="configSetsHandler">testConfigSetsHandler</str>
<str name="managementPath">testManagementPath</str>
<str name="sharedLib">testSharedLib</str>
+ <str name="allowPaths">/tmp,/home/john</str>
Review comment:
ok... I suppose both could be supported provided that the consumer
checked with the aid of some new utility method that doesn't exist like
`Utils.toListOfString(Object, char separator) : String` but that might be a bit
much. I suspect we have other places where we trivially use a delimited string
and fail to leverage NamedList. Your call; no strong opinion here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
