s1monw commented on a change in pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r442023300
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -3255,7 +3302,16 @@ private long prepareCommitInternal() throws IOException {
} finally {
maybeCloseOnTragicEvent();
}
-
+
+ if (onCommitMerges != null) {
+ mergeScheduler.merge(mergeSource, MergeTrigger.COMMIT);
Review comment:
the last thing that I am afraid about is what if we has a MergeScheduler
configured that blocks on this call like SerialMergeScheduler? I think there
are multiple options like: documentation, skipping `COMMIT` merge triggers in
SMS, adding a mergeAsync method to MS that has no impl in SMS... I think we
should make sure that this is not trappy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
