s1monw commented on a change in pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r442167608
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -3255,7 +3302,16 @@ private long prepareCommitInternal() throws IOException {
} finally {
maybeCloseOnTragicEvent();
}
-
+
+ if (onCommitMerges != null) {
+ mergeScheduler.merge(mergeSource, MergeTrigger.COMMIT);
Review comment:
yeah I mean we don't have to do that and I think its rather a rare
combination. My problem is that this entire configuration of max wait time is
nonsense if SerialMS is used since we block until it has merged them all and
potentially a bunch of other merges to a commit / refresh could take quite a
long time. On the other hand, as you stated we will call maybeMerge anyway in
the commit such that it's not really making any difference and the same is true
for getReader so I think we are fine as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
