ErickErickson commented on a change in pull request #1579: URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445257281
########## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java ########## @@ -305,10 +303,10 @@ public boolean equals(Object o) { return properties.equals(that.properties); } -// @Override -// public int hashCode() { -// throw new UnsupportedOperationException("TODO unimplemented"); -// } + @Override + public int hashCode() { + return Objects.hash(name, actionClass); Review comment: equals doesn't even include name, so I guess it'll just have to be properties only to conform to the contract. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org