ErickErickson commented on a change in pull request #1579:
URL: https://github.com/apache/lucene-solr/pull/1579#discussion_r445260567
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java
##########
@@ -587,11 +585,11 @@ public boolean equals(Object o) {
if (!getTriggerListenerConfigs().equals(that.getTriggerListenerConfigs()))
return false;
return getProperties().equals(that.getProperties());
}
-// @Override
-// public int hashCode() {
-// throw new UnsupportedOperationException("TODO unimplemented");
-// }
+ @Override
+ public int hashCode() {
+ return Objects.hash(policy, zkVersion);
Review comment:
Looks like this just needs to be a hash on getPolicy(). I don't think it
can even be the member var policy since getPolicy can change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
