dsmiley commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r448699301
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##########
@@ -510,14 +510,18 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
}
private void tagRequestWithRequestId(ResponseBuilder rb) {
- String rid = getRequestId(rb.req);
- if (StringUtils.isBlank(rb.req.getParams().get(CommonParams.REQUEST_ID))) {
- ModifiableSolrParams params = new
ModifiableSolrParams(rb.req.getParams());
- params.add(CommonParams.REQUEST_ID, rid);//add rid to the request so
that shards see it
- rb.req.setParams(params);
- }
- if (rb.isDistrib) {
- rb.rsp.addToLog(CommonParams.REQUEST_ID, rid); //to see it in the logs
of the landing core
+ final String disableFlag =
rb.req.getParams().get(CommonParams.DISABLE_REQUEST_ID);
Review comment:
Having to disable one parameter showing up by adding another parameter
kinda defeats the point. To some people, this new parameter is needless noise.
To them, your solution is to tell them to add more noise (another param) to
make that one go away. I don't understand why users would toggle this on a
query-by-query basis. I suspect people holistically like this new ID on all
their requests, or they don't. But maybe you have something in mind? I
suppose it *could* be both -- you set the default as a cluster property but
allow an override for the request. Hmm; yeah I rather like that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
