[
https://issues.apache.org/jira/browse/LUCENE-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161665#comment-17161665
]
Lucene/Solr QA commented on LUCENE-9437:
----------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
13s{color} | {color:red} facet in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 13s{color}
| {color:red} facet in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}
0m 13s{color} | {color:red} facet in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Check forbidden APIs {color} | {color:red}
0m 13s{color} | {color:red} facet in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Validate source patterns {color} |
{color:red} 0m 13s{color} | {color:red} facet in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 4s{color}
| {color:red} facet in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 45s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-9437 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13008042/LUCENE-9437.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-108-generic #109-Ubuntu SMP Fri Jun 19
11:33:10 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 48e92ba9c74 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| compile |
https://builds.apache.org/job/PreCommit-LUCENE-Build/285/artifact/out/patch-compile-lucene_facet.txt
|
| javac |
https://builds.apache.org/job/PreCommit-LUCENE-Build/285/artifact/out/patch-compile-lucene_facet.txt
|
| Release audit (RAT) |
https://builds.apache.org/job/PreCommit-LUCENE-Build/285/artifact/out/patch-compile-lucene_facet.txt
|
| Check forbidden APIs |
https://builds.apache.org/job/PreCommit-LUCENE-Build/285/artifact/out/patch-compile-lucene_facet.txt
|
| Validate source patterns |
https://builds.apache.org/job/PreCommit-LUCENE-Build/285/artifact/out/patch-compile-lucene_facet.txt
|
| unit |
https://builds.apache.org/job/PreCommit-LUCENE-Build/285/artifact/out/patch-unit-lucene_facet.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/285/testReport/ |
| modules | C: lucene/facet U: lucene/facet |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/285/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Make DocValuesOrdinalsReader.decode(BytesRef, IntsRef) method publicly
> accessible
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-9437
> URL: https://issues.apache.org/jira/browse/LUCENE-9437
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 8.6
> Reporter: Ankur
> Priority: Trivial
> Attachments: LUCENE-9437.patch
>
>
> Visibility of _DocValuesOrdinalsReader.decode(BytesRef, IntsRef)_ method is
> set to 'protected'. This prevents the method from being used outside this
> class in a setting where BinaryDocValues reader is instantiated outside the
> class and binary payload containing ordinals still needs to be decoded.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
