[
https://issues.apache.org/jira/browse/SOLR-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166682#comment-17166682
]
ASF subversion and git services commented on SOLR-14651:
--------------------------------------------------------
Commit a3624029ad262489b091d9a474430359f782d307 in lucene-solr's branch
refs/heads/master from David Smiley
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a362402 ]
SOLR-14651: Metrics History could disable better (#1672)
* SolrRrdBackendFactory should not be created if history is disabled
* Disable MetricsHistoryHandler by default in tests
* Await shutdown of all executors
> Metrics history could disable itself better
> -------------------------------------------
>
> Key: SOLR-14651
> URL: https://issues.apache.org/jira/browse/SOLR-14651
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The MetricsHistoryHandler should disable itself better than it does. It will
> create a SolrRrdBackendFactory (which has an ExecutorService / thread pool)
> when it should not when the plugin is disabled. Furthermore, I think this
> should be disabled by default in tests, as it's excessive machinery that
> don't matter to 99.9% of tests. This will help our tests run more
> efficiently.
> While working on other issues, I also occasionally saw a thread leak failure
> with the RRD being the leaked threads. I see that in "close", we don't
> _wait_ for the executor to actually shut down but it should.
> CC [~ab]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
