s1monw commented on a change in pull request #1623:
URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r471960276



##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -630,6 +694,64 @@ DirectoryReader getReader(boolean applyAllDeletes, boolean 
writeAllDeletes) thro
     return r;
   }
 
+  private StandardDirectoryReader finishGetReaderMerge(AtomicBoolean 
hasTimedOut, Map<String, SegmentReader> mergedReaders,
+                                                       Map<String, 
SegmentReader> openedReadOnlyClones, SegmentInfos openingSegmentInfos,
+                                                       boolean 
applyAllDeletes, boolean writeAllDeletes,
+                                                       
MergePolicy.MergeSpecification onCommitMerges, long maxCommitMergeWaitMillis) 
throws IOException {
+    boolean replaceReaderSuccess = false;
+    try {
+      mergeScheduler.merge(mergeSource, MergeTrigger.GET_READER);
+      onCommitMerges.await(maxCommitMergeWaitMillis, TimeUnit.MILLISECONDS);
+      assert openingSegmentInfos != null;
+      synchronized (this) {
+        hasTimedOut.set(true);

Review comment:
       I renamed it to `stopCollectingMergedReaders`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to