s1monw commented on a change in pull request #1623:
URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r471991665
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -607,6 +633,57 @@ DirectoryReader getReader(boolean applyAllDeletes, boolean
writeAllDeletes) thro
}
}
}
+ if (onCommitMerges != null) { // only relevant if we do merge on
getReader
+ boolean replaceReaderSuccess = false;
+ try {
+ mergeScheduler.merge(mergeSource, MergeTrigger.GET_READER);
+ onCommitMerges.await(maxCommitMergeWaitMillis,
TimeUnit.MILLISECONDS);
Review comment:
I'd not want to add another option to IWC unless absolutely necessary.
Maybe we can just keep one for now and if somebody has a good usecase we can
still add? I think we have the ability to disable it entirely for one or the
other trigger which should be enough in most cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
