dsmiley commented on pull request #1770: URL: https://github.com/apache/lucene-solr/pull/1770#issuecomment-684902621
It's not obvious but if we return the result of CF.exceptionaly() then *somehow* we need to ensure that the original CF can get completed for the handler we add here to even get called. It's not obvious; took some playing with simple Java scratch files. If we do nothing with the result of CF.exceptionally then the handler added there *will* get called (assuming there's an exception of course). You can think of it like a chain or tree. We need to keep the head/root of the chain and use that to trigger the actions along the chain. If we pass the tail of the chain, then it's useless. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
