rishisankar commented on a change in pull request #1770:
URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r474836063
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
##########
@@ -1167,8 +1191,38 @@ public RouteException(ErrorCode errorCode,
NamedList<Throwable> throwables, Map<
}
LBSolrClient.Req req = new LBSolrClient.Req(request, theUrlList);
- LBSolrClient.Rsp rsp = getLbClient().request(req);
- return rsp.getResponse();
+ if (isAsyncRequest) {
+ CompletableFuture<LBSolrClient.Rsp> lbFuture = ((LBHttp2SolrClient)
getLbClient()).requestAsync(req);
Review comment:
I agree -- added a quick documentation comment of this on the
makeRequest method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
