murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686368990
> On the other hand, Ilan wrote this on Slack: > > > If there’s consensus for Noble’s approach (or for that matter no consensus that goals 1-3 above are good guiding principles), I will stop work on SOLR-14613 and move on to other unrelated topics. > > Such threats of "stop work" unless one's design is agreed upon should cease, and constructive ways to collaborate should be explored. @chatman I likely didn't express myself clearly enough: all (all!) my work in this PR is guided by these 3 principles. If we don't agree on those, my work doesn't make sense and is indeed too verbose and complex for no reason! I did not ask anybody to agree with my design, but to agree with the goals. Implementing directly to the `Assign` interface is what we did at Salesforce to run 8x (too broken otherwise) and what we can and possibly will do to run SolrCloud in production. Goals 1-3 (copied below from Slack for reference) are to make this type of dev easier by contributors that might not have the expertise or time to code directly to existing Solr abstractions. > **1. placement plugin writing is easy**, **2. implementation for this placement API is efficient**, and **3. plugins do not break when Solr is refactored** (plugins might be client private so can’t be refactored when Solr code changes). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
