dweiss commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686928388
I'll take a look later as to why this doesn't build. The problem with individual suppressions remains though - you can go by category but I think there will be still places where false positives need to be marked as such (so that they don't generate a warning). We will need a mechanism to individually flag such places as "valid use" - this applies to reference comparisons in particular (which may be a bug or may be intentional, depending on the intention of the programmer). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
