dweiss commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686292245
bq. While some warnings are disputable, most of these point to genuine errors or deficiencies - this looks very useful! Right. This is always my problem with static analysis tools - if you can't somehow mark or suppress warnings in places where the code is valid (comparing references, for example) then the tool becomes a burden to maintain - the list of warnings will just pile up without anyone looking. bq. To get this plugin integrated ( without fixing all the warnings/errors ) we'd need to set this options.errorprone.allErrorsAsWarnings = true and remove "-Werror", from the defaults-java.gradle file I'm against removing -Werror from compiler options. We can make this plugin run as an option but -Werror should be the default for anyone else. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
