s1monw commented on a change in pull request #1847: URL: https://github.com/apache/lucene-solr/pull/1847#discussion_r487721690
########## File path: lucene/core/src/java/org/apache/lucene/util/Accountable.java ########## @@ -41,4 +41,8 @@ return Collections.emptyList(); } + /** + * An accountable that always returns 0 + */ + Accountable NULL_ACCOUNTABLE = () -> 0; Review comment: sure, but do we then initialize all booleans with `= false`? I thinks it's totally obsolet. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org