goankur commented on a change in pull request #1893:
URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r494665188
##########
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetCounts.java
##########
@@ -726,6 +743,39 @@ public void testRandom() throws Exception {
IOUtils.close(tw, searcher.getIndexReader(), tr, indexDir, taxoDir);
}
+ private static List<List<FacetLabel>>
sortedFacetLabels(List<List<FacetLabel>> allfacetLabels) {
+ for (List<FacetLabel> facetLabels : allfacetLabels) {
+ Collections.sort(facetLabels);
+ }
+
+ Collections.sort(allfacetLabels, (o1, o2) -> {
Review comment:
Yes, a document with `N`<sup>th</sup> position in the input sequence
might end up with `K`<sup>th</sup> docId in a random segment making it harder
to compare actual and expected labels.
Thanks for confirming that the approach is acceptable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
