rmuir commented on a change in pull request #1950: URL: https://github.com/apache/lucene-solr/pull/1950#discussion_r501401503
########## File path: gradle/validation/spotless.gradle ########## @@ -0,0 +1,31 @@ + +def resources = scriptResources(buildscript) + +allprojects { prj -> + plugins.withType(JavaPlugin) { + prj.apply plugin: 'com.diffplug.spotless' + + spotless { + java { + licenseHeaderFile file("${resources}/asl-header.txt"), '^(\\s*package)' + lineEndings 'UNIX' + endWithNewline() + googleJavaFormat('1.9') + + // Known problematic files. + targetExclude "**/HTMLStripCharFilter.java", "**/UAX29URLEmailTokenizerImpl.java", + "**/PatternParser.java", "**/BuildNavDataFiles.java", "**/CheckLinksAndAnchors.java", + "**/TestSubQueryTransformer.java" Review comment: can we exempt other generated files? Otherwise it will make a lot of regeneration tasks stuff no longer idempotent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org