uschindler commented on pull request #1966:
URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705738171


   The problem why you hit the exception is wrong implementation. Don't look at 
tokens before calling incrementToken().
   In addition, you must call addAttribute() before the loop, so the 
FlagsAttribute instance is created before. Please drop the whole PR. It's plain 
wrong.
   
   Most of tests are not needed if you implement FilteringTokenFilter.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to