uschindler commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705768959
Your filter does not handle positions at all, so it will also corrupt the graph of later tokens are removed. It's a state machine and you have to understand it. Your problem was thought about years ago, there's no need for discussion. Sorry for being harsh, but I fortunately I have to say: your work does not follow any documentation about how a tokenfilters should behave. If you read javadocs it's all explained. The whole thing is plain wrong an using that at the Library of Congress would feel me really bad... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
