muse-dev[bot] commented on a change in pull request #2010:
URL: https://github.com/apache/lucene-solr/pull/2010#discussion_r517712472



##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java
##########
@@ -235,11 +234,11 @@ public String getName() {
   }
 
   public String getCoreUrl() {
-    return ZkCoreNodeProps.getCoreUrl(getStr(ZkStateReader.BASE_URL_PROP), 
core);
+    return ZkCoreNodeProps.getCoreUrl(getBaseUrl(), core);

Review comment:
       *NULL_DEREFERENCE:*  object returned by `getBaseUrl()` could be null and 
is dereferenced by call to `getCoreUrl(...)` at line 237.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to