mayya-sharipova commented on a change in pull request #2063:
URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518800810
##########
File path:
lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java
##########
@@ -485,4 +491,249 @@ public void testDocSort() throws IOException {
dir.close();
}
+ public void testNumericSortOptimizationIndexSort() throws IOException {
+ final Directory dir = newDirectory();
+ IndexWriterConfig iwc = new IndexWriterConfig(new MockAnalyzer(random()));
+ boolean reverseSort = randomBoolean();
+ final SortField sortField = new SortField("field1", SortField.Type.LONG,
reverseSort);
+ Sort indexSort = new Sort(sortField);
+ iwc.setIndexSort(indexSort);
+ final IndexWriter writer = new IndexWriter(dir, iwc);
+
+ final int numDocs = atLeast(50);
+ int[] sortedValues = initializeNumericValues(numDocs, reverseSort, 0);
+ int[] randomIdxs = randomIdxs(numDocs);
+
+ for (int i = 0; i < numDocs; i++) {
+ final Document doc = new Document();
+ if (sortedValues[randomIdxs[i]] > 0) {
+ doc.add(new NumericDocValuesField("field1",
sortedValues[randomIdxs[i]]));
+ }
+ writer.addDocument(doc);
+ if (i == 30) {
+ writer.flush();
+ }
+ }
+ final IndexReader reader = DirectoryReader.open(writer);
+ writer.close();
Review comment:
Thank you, good suggestion. Addressed in c52d9a7
##########
File path:
lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java
##########
@@ -485,4 +491,249 @@ public void testDocSort() throws IOException {
dir.close();
}
+ public void testNumericSortOptimizationIndexSort() throws IOException {
+ final Directory dir = newDirectory();
+ IndexWriterConfig iwc = new IndexWriterConfig(new MockAnalyzer(random()));
+ boolean reverseSort = randomBoolean();
+ final SortField sortField = new SortField("field1", SortField.Type.LONG,
reverseSort);
+ Sort indexSort = new Sort(sortField);
+ iwc.setIndexSort(indexSort);
+ final IndexWriter writer = new IndexWriter(dir, iwc);
+
+ final int numDocs = atLeast(50);
+ int[] sortedValues = initializeNumericValues(numDocs, reverseSort, 0);
+ int[] randomIdxs = randomIdxs(numDocs);
+
+ for (int i = 0; i < numDocs; i++) {
+ final Document doc = new Document();
+ if (sortedValues[randomIdxs[i]] > 0) {
+ doc.add(new NumericDocValuesField("field1",
sortedValues[randomIdxs[i]]));
+ }
+ writer.addDocument(doc);
+ if (i == 30) {
+ writer.flush();
+ }
+ }
+ final IndexReader reader = DirectoryReader.open(writer);
+ writer.close();
+
+ IndexSearcher searcher = newSearcher(reader);
+ final int numHits = randomIntBetween(1, numDocs - 10);
+ final int totalHitsThreshold = randomIntBetween(1, numDocs - 10);
+ {
Review comment:
Addressed in c52d9a7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
