cpoerschke commented on pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#issuecomment-726414214
Hi @alessandrobenedetti, I returned to this pull request today, both the changes above and the tests (which I hadn't looked at before). Very comprehensive test coverage, thank you. Have pushed all my remaining insights to the https://github.com/cpoerschke/lucene-solr/commits/feature/SOLR-14560-cpoerschke-2 branch -- for the https://github.com/cpoerschke/lucene-solr/commit/4912daccd596435f5c61ac1a3cf86eaebb039118 and https://github.com/cpoerschke/lucene-solr/commit/3a61287a0e4fb5a77f080a92e7129582b234cbd7 commits which are perhaps a bit subtle I've added annotations on the pull request here -- the other commits are hopefully relatively self-explanatory. Let me know what you think, I agree the commit phase is fast approaching here :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
