cpoerschke commented on pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#issuecomment-729102552
> ... is there any automatic tool that will remove them ... If not I suspect we may risk forgetting ... I'm not aware of any automatic tool we currently use that would remove deprecated code, only that possibly(?) somewhere there might be warnings(?) identifying deprecated API use. One possible approach to avoid removal being forgotten is to carry it out right away i.e. the full commit happens for master branch and gets cherry-picked to branch_8x and then right away after that there is an additional separate commit (without a solr/CHANGES.txt entry since it's just code cleanup) for master branch only to remove the deprecated stuff. The additional commit is not cherry-picked to branch_8x and in future when branch_9x is cut from master branch (and then branch_9_0 is cut from branch_9x) the deprecated stuff is already gone then. Happy for you to decide either way and commit away tomorrow :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
