zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525747082
##########
File path: lucene/misc/native/src/main/posix/NativePosixUtil.cpp
##########
@@ -102,6 +102,7 @@ JNIEXPORT jint JNICALL
Java_org_apache_lucene_misc_store_NativePosixUtil_posix_1
}
#endif
+// TODO: To be removed together?
Review comment:
> This should really be a // nocommit right? I.e. we want to solve this
question before committing, and we don't plan to commit this // TODO.
Ops sorry, didn't realize the nocommit usage there. Will use it for future
patches.
> I'd like to get rid of it as soon as possible. This class is obsolete and
completely unused, unless we also keep the original directory implementation.
I've removed them in latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
