zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r535812210



##########
File path: lucene/misc/native/build.gradle
##########
@@ -51,11 +47,7 @@ tasks.withType(CppCompile).configureEach {
   // is present.
   systemIncludes.from file("${javaHome}/include")
 
-  for (def path : [

Review comment:
       > Sorry for dropping off the radar a bit. It looks good to me. It is a 
pity we can't drop native builds on Windows too!
   
   No problem, and thanks again for your review and comment on this PR! I would 
feel sad to see all of native build code gone at once actually. So this helps 
soften the blow :D




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to