murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r545160385
##########
File path:
solr/core/src/java/org/apache/solr/cluster/placement/AttributeFetcher.java
##########
@@ -70,6 +71,12 @@
*/
AttributeFetcher requestNodeMetric(String metricName, NodeMetricRegistry
registry);
+ /**
+ * Request collection-level metrics. To get the values use {@link
AttributeValues#getCollectionMetrics(String)}.
+ * Note that this request will fetch information from nodes relevant to the
collection
+ * replicas and not the ones specified in {@link #fetchFrom(Set)} (though
they may overlap).
+ */
+ AttributeFetcher requestCollectionMetrics(SolrCollection solrCollection,
Set<ReplicaMetric<?>> metricNames);
Review comment:
`metricNames` is not a good name, there are not just names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
