murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546775011
########## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/CollectionMetricsBuilder.java ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cluster.placement.impl; + +import org.apache.solr.cluster.placement.CollectionMetrics; +import org.apache.solr.cluster.placement.ReplicaMetrics; +import org.apache.solr.cluster.placement.ShardMetrics; + +import java.util.HashMap; +import java.util.Map; +import java.util.Optional; + +/** + * + */ +public class CollectionMetricsBuilder { + + final Map<String, ShardMetricsBuilder> shardMetricsBuilders = new HashMap<>(); + + + public Map<String, ShardMetricsBuilder> getShardMetricsBuilders() { + return shardMetricsBuilders; + } + + public CollectionMetrics build() { + final Map<String, ShardMetrics> metricsMap = new HashMap<>(); + shardMetricsBuilders.forEach((shard, builder) -> metricsMap.put(shard, builder.build())); + return shardName -> Optional.ofNullable(metricsMap.get(shardName)); + } + + public static class ShardMetricsBuilder { + final Map<String, ReplicaMetricsBuilder> replicaMetricsBuilders = new HashMap<>(); + + public Map<String, ReplicaMetricsBuilder> getReplicaMetricsBuilders() { + return replicaMetricsBuilders; + } + + public ShardMetricsBuilder setLeaderMetrics(ReplicaMetricsBuilder replicaMetricsBuilder) { + replicaMetricsBuilders.put(LEADER, replicaMetricsBuilder); + return this; + } + + static final String LEADER = "__leader__"; Review comment: I'd rather have a dedicated variable in the `ShardMetricsBuilder` referencing the leader's `ReplicaMetricsBuilder` instance and a dedicated variable in the anonymous subclass of `ShardMetrics` doing the same. Will be cleaner to read and not less efficient. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
