murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r546776315
##########
File path: solr/core/src/test/org/apache/solr/cluster/placement/Builders.java
##########
@@ -48,7 +49,11 @@ public static CollectionBuilder newCollectionBuilder(String
collectionName) {
public ClusterBuilder initializeLiveNodes(int countNodes) {
nodeBuilders = new LinkedList<>();
for (int n = 0; n < countNodes; n++) {
- nodeBuilders.add(new NodeBuilder().setNodeName("node_" + n)); //
Default name, can be changed
+ NodeBuilder nodeBuilder = new NodeBuilder().setNodeName("node_" + n);
// Default name, can be changed
+ nodeBuilder.setTotalDiskGB(10000.0);
+ nodeBuilder.setFreeDiskGB(5000.0);
+ nodeBuilder.setDiskType(AttributeFetcher.DiskHardwareType.SSD);
Review comment:
I thought disk type was going away?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
