[
https://issues.apache.org/jira/browse/LUCENE-9658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260532#comment-17260532
]
Dawid Weiss commented on LUCENE-9658:
-------------------------------------
bq. `check -x test` that's OK once we learn to remember it (I didn't know about
`-x`).
Exactly. I think it's going to be educational too. That '-x' can be used in
other contexts as well - for example to run all checks except x, y, z... Also,
check is defined on all projects (as opposed to precommit) so you can run:
{code}
gradlew -p lucene check -x test
{code}
and this will run all checks for lucene (and sub-projects) skipping test tasks.
These are valuable gradle conventions to learn as they're applicable to other
things, not just precommit checks.
> Make 'precommit' an alias for gradle 'check' task.
> --------------------------------------------------
>
> Key: LUCENE-9658
> URL: https://issues.apache.org/jira/browse/LUCENE-9658
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Major
>
> A separate precommit task is clumsy and error prone. This was done to support
> back-compatibility with ant but I think it should be removed in favor of the
> gradle-convention 'check'.
> The only difference precommit currently has from check is that it doesn't run
> tests. People who want to bypass tests can still run check with:
> {code}
> ./gradlew check -x test
> {code}
> which excludes all test tasks from running.
> We can make precommit an alias to check at first ({{precommit.dependsOn
> check}}) and perhaps disable all tests manually so that it is compatible with
> the previous behavior. I'll add an info-box at the end to instruct people how
> to run check without tests too.
> The benefit of using check is that you can run it selectively on subprojects
> and that there is no need for extra plumbing to attach validation tasks to it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
