donnerpeter commented on a change in pull request #2267:
URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568394955
##########
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/SpellCheckerTest.java
##########
@@ -61,59 +61,74 @@ public void needAffixOnAffixes() throws Exception {
doTest("needaffix5");
}
+ @Test
public void testBreak() throws Exception {
doTest("break");
}
- public void testBreakDefault() throws Exception {
+ @Test
+ public void breakDefault() throws Exception {
doTest("breakdefault");
}
- public void testBreakOff() throws Exception {
+ @Test
+ public void breakOff() throws Exception {
doTest("breakoff");
}
- public void testCompoundrule() throws Exception {
+ @Test
+ public void compoundrule() throws Exception {
doTest("compoundrule");
}
- public void testCompoundrule2() throws Exception {
+ @Test
+ public void compoundrule2() throws Exception {
doTest("compoundrule2");
}
- public void testCompoundrule3() throws Exception {
+ @Test
+ public void compoundrule3() throws Exception {
doTest("compoundrule3");
}
- public void testCompoundrule4() throws Exception {
+ @Test
+ public void compoundrule4() throws Exception {
doTest("compoundrule4");
}
- public void testCompoundrule5() throws Exception {
+ @Test
+ public void compoundrule5() throws Exception {
doTest("compoundrule5");
}
- public void testCompoundrule6() throws Exception {
+ @Test
+ public void compoundrule6() throws Exception {
doTest("compoundrule6");
}
- public void testCompoundrule7() throws Exception {
+ @Test
+ public void compoundrule7() throws Exception {
doTest("compoundrule7");
}
- public void testCompoundrule8() throws Exception {
+ @Test
+ public void compoundrule8() throws Exception {
doTest("compoundrule8");
}
- public void testGermanCompounding() throws Exception {
+ @Test
+ public void germanCompounding() throws Exception {
doTest("germancompounding");
}
protected void doTest(String name) throws Exception {
- InputStream affixStream =
- Objects.requireNonNull(getClass().getResourceAsStream(name + ".aff"),
name);
- InputStream dictStream =
- Objects.requireNonNull(getClass().getResourceAsStream(name + ".dic"),
name);
+ checkSpellCheckerExpectations(
Review comment:
Thanks for looking into this and for your patch! I've no idea why you
can't push, I've got the checkbox enabled on this PR:
That's what
https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork
seems to recommend. I also checked the repository settings and couldn't find
an option about committers. I can invite you personally though :)
By renaming do you mean `TestSpellChecker`? I'll do it, thanks for the
suggestion, but preferably a bit later, when there won't be so much merging
around this class :)
BTW what do you think about renaming `SpellChecker` into `Hunspell`?
##########
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestsFromOriginalHunspellRepository.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.analysis.hunspell;
+
+import java.io.IOException;
+import java.nio.file.DirectoryStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.text.ParseException;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.stream.Collectors;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+/**
+ * Same as {@link SpellCheckerTest}, but checks all Hunspell's test data. The
path to the checked
+ * out Hunspell repository should be in {@code -Dhunspell.repo.path=...}
system property.
+ */
+@RunWith(Parameterized.class)
Review comment:
Thanks! Now I'm starting to doubt whether this approach makes sense at
all. I could avoid parameterization by generating test methods explicitly by
files, with some risk that new files appear (which could be checked by
additional code).
And is it OK to modify the test policy for such local tests? I planned to
add more not-easy-to-have-in-CI tests, which would measure performance and
check correctness. They'd need external files with dictionaries, corpora for
various languages (external or is there anything internal already?), and a
test-only Hunspell JNI library for comparison (which needs a native binary and
a couple of other jars, all of them need sha and license files, and it all gets
quite verbose). Do you think the benefits of having this in the repo outweigh
the costs? I could also leave this all locally, since I seem to be the only one
needing these tests in the near future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
