zacharymorn commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-804683838


   Thanks Robert for working on this! And yeah I didn't quite anticipate so 
much dead code lingering around when I created the issue! From your latest 
comment this PR is very much ready now? Any aspect I can still look into in 
this PR to help out as well at this point? (and sorry for coming in late in the 
discussion!)
   
   In addition, I have a newbie question. It appears error prone was integrated 
fairly recently this year https://issues.apache.org/jira/browse/LUCENE-9497, 
but the issue itself didn't seems to mention why error prone was needed when 
there's already ecj lint, and which one should be preferred for which scenario. 
Is the plan to have both ecj & error prone to co-exist in Lucene to catch 
different kinds of bugs?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to