uschindler commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599500002



##########
File path: gradle/generation/javacc.gradle
##########
@@ -95,6 +95,12 @@ def commonCleanups = { FileTree generatedFiles ->
       text = text.replace(
           "public  void setDebugStream(java.io.PrintStream ds) { debugStream = 
ds; }",
           "// (setDebugStream omitted).")
+      text = text.replace(
+          "public class QueryParserTokenManager ",
+          "@SuppressWarnings(\"unused\") public class QueryParserTokenManager 
")

Review comment:
       That's fine. I generally try to avoid double quotes in groovy, because I 
hate the case that it expands variables inside. Personally, I see languages 
expanding variables inside strings as a security risk.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to