nitirajrathore commented on a change in pull request #55:
URL: https://github.com/apache/lucene/pull/55#discussion_r604604635
##########
File path: lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java
##########
@@ -34,15 +34,15 @@
// Used to track the number of neighbors visited during a single graph
traversal
private int visitedCount;
- NeighborQueue(int initialSize, boolean reversed) {
+ public NeighborQueue(int initialSize, boolean reversed) {
Review comment:
Yes, Initially I created FullKnn.java in same package called `hnsw`. But
it does not make sense to have different algorithm in the package name and
different algorithm (exact knn) in class. I think we don't need the
NeighborQueue at all here, it can directly be implemented with LongHeap, I will
attempt that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
