rmuir commented on a change in pull request #119: URL: https://github.com/apache/lucene/pull/119#discussion_r624452579
########## File path: gradle/testing/coverage.gradle ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +if (Boolean.parseBoolean(propertyOrDefault("tests.coverage", "false"))) { + allprojects { + apply plugin: "jacoco" + tasks.withType(Test) { + // XXX: too many things called "workingDir" in gradle! + def targetDir = "${buildDir}/tmp/tests-cwd" Review comment: @dweiss one thing is the fact that jacoco runs in append-mode. We don't want to just keep accumulating coverage over unrelated `gradle test` runs. The append-only mode serves a separate purpose, that is to allow N test jvms to append to the same output database (just saves us a merging step, really) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
