gsmiller commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-834786325
@rmuir just posted a new revision that optimizes non-overlapping range cases with its own implementation. It's a pretty big change from the previous version, but I'm curious to see what you think. It should be functionally correct (unit tests seem to agree at least) but I haven't done any bechmarking yet. I'm sure the code could be cleaned up a little bit as well, but I went ahead and put the revision up as-is to see if you think this makes more sense directionally than what I'd done previously. It still requires the startDoc + add + endDoc dance for multi-valued docs, but is maybe a bit more optimal. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
