[ 
https://issues.apache.org/jira/browse/LUCENE-9956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344047#comment-17344047
 ] 

Greg Miller commented on LUCENE-9956:
-------------------------------------

It seems reasonable to me to make this method public, but maybe I'm overlooking 
some good reasons why this should be inaccessible outside of the facet package.

For consistency, I wonder if it makes sense to think about exposing the drill 
down dimension queries as well. Seems a little narrow to only expose the base 
query but not the drill down dim queries. So I might think a little more 
broadly on what internal details make sense to expose, and do it together.

> Make getBaseQuery API from DrillDownQuery public 
> -------------------------------------------------
>
>                 Key: LUCENE-9956
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9956
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>    Affects Versions: main (9.0)
>            Reporter: Gautam Worah
>            Priority: Trivial
>
> It would be great if users could access the baseQuery of a DrillDownQuery. I 
> think this can be useful for folks who want to access/test the clauses of a 
> BooleanQuery (for example) after they've already wrapped it into a 
> DrillDownQuery.
>  
>  Currently the {{Query getBaseQuery()}} method is package private by default.
> If this proposed change does not make sense, or if this change breaks the 
> semantic of the class, I am happy to explore other ways of doing this!
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to