zacharymorn commented on a change in pull request #240:
URL: https://github.com/apache/lucene/pull/240#discussion_r697155622
##########
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/ReadTask.java
##########
@@ -180,6 +185,7 @@ protected int withTopDocs(IndexSearcher searcher, Query q,
TopDocs hits) throws
return res;
}
+ @Deprecated
Review comment:
I see where you are coming from. However, upon looking at this method
more closely, I'm afraid this method is effectively not useful, since the
result of using this collector was commented out :D :
https://github.com/apache/lucene/blob/3b3f9600c2ea6023f5400a364c0921ba29667584/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/ReadTask.java#L119-L121
So I'm now leaning more towards just removing this method altogether if no
users ever noticed / complaint about this. What do you think @gsmiller
@jpountz ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
