zacharymorn commented on a change in pull request #240:
URL: https://github.com/apache/lucene/pull/240#discussion_r699834253
##########
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -209,61 +212,14 @@ public static TopScoreDocCollector create(int numHits,
int totalHitsThreshold) {
*
* <p><b>NOTE</b>: The instances returned by this method pre-allocate a full
array of length
* <code>numHits</code>, and fill the array with sentinel objects.
+ *
+ * @deprecated This method is being deprecated in favor of using the
constructor of {@link
+ * TopScoreDocCollectorManager} due to its support for concurrency in
IndexSearcher
*/
+ @Deprecated
public static TopScoreDocCollector create(int numHits, ScoreDoc after, int
totalHitsThreshold) {
- return create(
- numHits, after,
HitsThresholdChecker.create(Math.max(totalHitsThreshold, numHits)), null);
- }
-
- static TopScoreDocCollector create(
Review comment:
Please see rely in
https://github.com/apache/lucene/pull/240#discussion_r699834141.
##########
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -209,61 +212,14 @@ public static TopScoreDocCollector create(int numHits,
int totalHitsThreshold) {
*
* <p><b>NOTE</b>: The instances returned by this method pre-allocate a full
array of length
* <code>numHits</code>, and fill the array with sentinel objects.
+ *
+ * @deprecated This method is being deprecated in favor of using the
constructor of {@link
+ * TopScoreDocCollectorManager} due to its support for concurrency in
IndexSearcher
*/
+ @Deprecated
public static TopScoreDocCollector create(int numHits, ScoreDoc after, int
totalHitsThreshold) {
- return create(
- numHits, after,
HitsThresholdChecker.create(Math.max(totalHitsThreshold, numHits)), null);
- }
-
- static TopScoreDocCollector create(
Review comment:
Please see reply in
https://github.com/apache/lucene/pull/240#discussion_r699834141.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
