rmuir commented on pull request #295:
URL: https://github.com/apache/lucene/pull/295#issuecomment-917803069


   If the user has java 16 or above, and we pass 
`-XX:+UnlockDiagnosticVMOptions -XX:+DumpPerfMapAtExit 
-XX:+PreserveFramePointer` to the JVM, we should get java symbol resolution 
from `perf` subsystem? Will it help this profiler? I think we can just add 
these args guarded by `if (rootProject.runtimeJavaVersion >= 
JavaVersion.VERSION_16) {` so that older JVMs still work tool. See 
https://bugs.openjdk.java.net/browse/JDK-8254723


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to