dweiss commented on a change in pull request #295:
URL: https://github.com/apache/lucene/pull/295#discussion_r707042543
##########
File path: gradle/testing/profiling.gradle
##########
@@ -43,6 +44,28 @@ allprojects {
}
}
}
+
+
+ if (resolvedTestOption("tests.asyncprofile").toBoolean()) {
+ allprojects {
+ tasks.withType(Test) {
+ jvmArgs("-javaagent:" +
project.rootProject.file('buildSrc/build/libs/buildSrc.jar').getAbsolutePath(),
"-XX:+UnlockDiagnosticVMOptions",
Review comment:
Here is another reason to move it to a composite - you could reference
the project's artifacts as a regular dependency, not a static path.
##########
File path: help/tests.txt
##########
@@ -157,6 +157,19 @@ to increase the top-N count:
gradlew -p lucene/core test -Ptests.profile=true -Ptests.profile.count=100
+nocommit - asyncprofile
Review comment:
Maybe move to help/profile.txt as it seems to be a larger issue on its
own rights?
##########
File path: gradle/testing/randomization/policies/tests.policy
##########
@@ -116,6 +116,14 @@ grant {
permission java.lang.RuntimePermission "defineClass";
};
+// Permissions for asyncprofiler
+grant {
+ // needed by jacoco to instrument classes
Review comment:
copy-paste (jacoco)?
##########
File path: buildSrc/build.gradle
##########
@@ -38,3 +38,11 @@ dependencies {
implementation
"commons-codec:commons-codec:${scriptDepVersions['commons-codec']}"
}
+jar {
Review comment:
Why is this in buildSrc? I think it should be another module entirely
(at the top-level) and just made a composite, much like
dev-tools/missing-doclet currently is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
