uschindler commented on pull request #308: URL: https://github.com/apache/lucene/pull/308#issuecomment-922775842
> I agree most of the cases where it is hardcoded needs to be taking into account vase by case. Exactly. Due to the deprecation warning we see those cases easily and more will come when we look into more `(<<|>>)\s*24` greps. > I remember seeing threads writing longs byte-by-byte via Lucene90PostingsWriter when capturing stack traces during indexing but I have no idea whether this is anecdotal or whether this is an actual bottleneck. That's OK. We can open a separate issue and look into improving DataOutput stuff, too. Currently not even `ByteArrayDataOutput` has primitive writes. It is easy to do (I have patch ready, so we can maybe add this here because it goes in line with `ByteArrayDataInput` (same code). `OutputStreamIndexOutput` would require a separate issue. Some hardcoded writes were already fixed by Robert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
