[ 
https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420782#comment-17420782
 ] 

Uwe Schindler commented on LUCENE-10125:
----------------------------------------

[~jpountz]: Yes, this can be done in buffered output stream. It should NOT be 
in FSIndexOutput.
[~rcmuir]: Thats exactly my plan (see the discussion in the PR)

I can work on a patch and use the new VarHandles to write the longs/ints/shorts 
directly into the buffer of the output stream. You need to add a bit of 
wrapping.

As Robert said in the issue: this was exactly why I made the suggestion to 
check if it is really an issue with performance. I already optimized 
ByteArrayDataOutput in the same way. Here the generic OutputStreamIndexOutput 
and its internal BufferedOutputStream instance needs the optimization, NOT 
FSDirectoryOutput!

> Investigate indexing throughput regression on NYC Taxis between 2021-04-12 
> and 2021-05-24
> -----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10125
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10125
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>
> There's been a significant drop in indexing throughput between 2021-04-12 and 
> 2021-05-24 on the NYC Taxis benchmark. Unfortunately several suspects have 
> been merged during that period of time so we might need to git bisect to 
> figure out which one is responsible for the regression. Interestingly the 
> sorted index looks less affected than the non-sorted indexes.
> https://home.apache.org/~mikemccand/lucenebench/sparseResults.html#index_throughput



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to