[ 
https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420800#comment-17420800
 ] 

Adrien Grand commented on LUCENE-10125:
---------------------------------------

I tried Robert's patch, generalizing it to shorts and longs, and I'm getting 
the exact same merge times with main+patch as on 
a7b0aadcfc9f5de120d240e7374bad762a05f1c7 (commit that was used to run 
benchmarks on 2021-04-12).

Maybe it would be cleaner if MyBufferedOutputStream implemented something like 
{{tryWriteLong}} rather than {{getBuffer}}/{{getCount}}/{{setCount}} to keep 
the internal state better encapsulated.

> Investigate indexing throughput regression on NYC Taxis between 2021-04-12 
> and 2021-05-24
> -----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10125
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10125
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-10125_hack.patch
>
>
> There's been a significant drop in indexing throughput between 2021-04-12 and 
> 2021-05-24 on the NYC Taxis benchmark. Unfortunately several suspects have 
> been merged during that period of time so we might need to git bisect to 
> figure out which one is responsible for the regression. Interestingly the 
> sorted index looks less affected than the non-sorted indexes.
> https://home.apache.org/~mikemccand/lucenebench/sparseResults.html#index_throughput



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to